Bug #128

Connects on addon load

Added by Adam Schmalhofer about 1 year ago. Updated about 1 year ago.

Status:Resolved Start:2009-06-17
Priority:Normal Due date:
Assigned to:- % Done:

100%

Category:- Spent time: -
Target version:1.1

Description

Blogit connects to the server as it is loaded. So every time vim is started a connection to the blog server is made. Raising privacy and security issues. Patch included.

blogit_connect.diff - Patch (986 Bytes) Adam Schmalhofer, 06/17/2009 12:20 am

blogit_connect.diff - Patch (1017 Bytes) Adam Schmalhofer, 06/17/2009 12:28 am

History

Updated by Adam Schmalhofer about 1 year ago

Fixed patch. Sorry. Note this is a diff to 261f4c16 + the patch blogit_passwd.diff in #62.

Updated by Romain Bignon about 1 year ago

  • Status changed from New to Resolved
  • Target version set to 12
  • % Done changed from 0 to 100

I think that create a ServerProxy object doesn't open a connection to the HTTP server, but only on each XML-RPC calls.

In doubt, I applied patch. Thank you.

Updated by Adam Schmalhofer about 1 year ago

It is not possible to compaire ServerProxy to None. That was my first try, too (sorry for not documenting it):

import xmlrpclib r = xmlrpclib.ServerProxy('http://blauebirke.wordpress.com/xmlrpc.php')

if not r: print 'no'
...
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python2.5/xmlrpclib.py", line 1147, in call
return self.__send(self.__name, args)
File "/usr/lib/python2.5/xmlrpclib.py", line 1437, in request
verbose=self.__verbose
File "/usr/lib/python2.5/xmlrpclib.py", line 1201, in request
return self._parse_response(h.getfile(), sock)
File "/usr/lib/python2.5/xmlrpclib.py", line 1340, in _parse_response
return u.close()
File "/usr/lib/python2.5/xmlrpclib.py", line 787, in close
raise Fault(**self._stack0)
xmlrpclib.Fault: <Fault -32601: 'server error. requested method __nonzero
does not exist.'>

Updated by Romain Bignon about 1 year ago

It's fixed. It needs to check if “self.client is None”, not “not self.client”…

Updated by Romain Bignon about 1 year ago

  • Target version changed from 12 to 1.1

Also available in: Atom PDF