Duplicate

Feature #198

Use IMlib to decode buddyicons

Added by Romain Bignon 9 months ago. Updated 5 months ago.

Status:Resolved Start:2009-12-19
Priority:Normal Due date:2010-04-05
Assigned to:Thomas Lecavelier % Done:

100%
Category:Core Spent time: 2.00 hours
Target version:1.0.2 Estimated time:2.00 hours
Branch:

Description

Currently, only .png can be sent to server as a buddy icon.

Use the IMlib to decode several image formats.

0002-failed-try-to-use-imlib2-for-buddyicons.-I-don-t-see.patch (2.3 KB) Romain Bignon, 04/01/2010 10:24 am

Associated revisions

Revision 67ff317ac06d4a2edb66624aae7cca16e4aef454
Added by Thomas Lecavelier 5 months ago

failed try to use imlib2 for buddyicons. I don't see why it crash, and I havn't enough experience to debug it (refs #198)

Revision 1d6244882357f6d962682734a28894b6bb421907
Added by Romain Bignon 5 months ago

fix the ook's patch to use imlib2 to convert received buddyicon file to right encoded image (refs #198)

History

#1
Updated by Romain Bignon 9 months ago

  • Category set to Core
  • Status changed from New to Assigned
  • Assigned to set to Thomas Lecavelier

#2
Updated by Thomas Lecavelier 6 months ago

As said on IRC, It'll be ImLib2, since minbinf already depend upon it.

#3
Updated by Romain Bignon 6 months ago

  • Target version changed from 1.1 to 1.0.3

#4
Updated by Romain Bignon 5 months ago

ook has written two patches about this ticket, but the task is not finished because there are bugs:

Le premier est applicable, il ne mange pas de pain. Le deuxième est bien
moisi, et je ne vois pas comment debugger. Par contre je me demande si ce
n'est pas g_get_complete_file ou le dcc_send qui corrompt les fichiers (va
voir dans /var/lib/minbif, le fichier copié, qui est le png imlib, est
corrompu aussi).

#5
Updated by Romain Bignon 5 months ago

  • Due date set to 2010-04-05
  • Target version changed from 1.0.3 to 1.0.2

#6
Updated by Thomas Lecavelier 5 months ago

Some precisions:

Patch 1: not related to this issue, but a test documentation enhancement
Patch 2: NON FUNCTIONNAL PATCH. It use imlib2 to convert any sent buddy images (so, no limitation to png file format) to png. I'm not enough proficient in C++ to debug the problem. Notice that the corrupted images could come from g_file_get_contents, since the file copied in /var/lib/minbif, which come from imlib2, is corrupted as well. Another possibility is a problem with dcc_send (last chunk missing?). So, issue still open, sorry.

#7
Updated by Thomas Lecavelier 5 months ago

  • File deleted (0001-add-instructions-to-config.py.example-and-warnings.patch)

#8
Updated by Thomas Lecavelier 5 months ago

First patch deleted and moved to #244

#9
Updated by Romain Bignon 5 months ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Wow, it wasn't really easy, but I think this is now fixed!

Duplicate

Also available in: Atom PDF