Feature #1641

Few new utility functions

Added by Oleg Plakhotniuk almost 3 years ago. Updated almost 3 years ago.

Status:Resolved Start:2014-10-11
Priority:Normal Due date:
Assigned to:- % Done:

100%

Category:Modules Spent time: -
Target version:1.0
Module: Branch:

Description

I factored out a few reusable functions from PayPal, Wells Fargo, and upcoming Citibank modules.

I've split the changes into several patches for convenience. One just adds new functions and tests, two others change the PayPal and Wells Fargo modules respectively.

Laurent, I saw you're in the middle of a global refactoring... I computed this patch against your branch (git://git.symlink.me/pub/laurentb/weboob.git). Thought it might be easier to merge it this way. Do let me know if I shall recompute it against some other branch though.


Related issues

blocks weboob - Feature #1642: Citibank module Resolved 2014-10-11

History

Updated by Oleg Plakhotniuk almost 3 years ago

BTW, I'm not sure how should I handle external dependencies, namely MuPDF in decompress_pdf function. For now I just described it in doctext...

Updated by Oleg Plakhotniuk almost 3 years ago

  • % Done changed from 0 to 100

Updated by Laurent Bachelier almost 3 years ago

Laurent, I saw you're in the middle of a global refactoring

Mostly code style fixes, I'm finished now and it's on the main branch, so you can rebase on it again instead of mine.
I try to make those before every release (v1.0 is to be released on Monday) so I don't break too many other's branches/patches and the stable branch ;)

I hope we can merge your latest patches for 1.0.

Updated by Laurent Bachelier almost 3 years ago

  • Assigned to deleted (Laurent Bachelier)
  • Target version set to 1.0

Updated by Oleg Plakhotniuk almost 3 years ago

  • File deleted (0001-American-amount-to-decimal-conversion-PDF-decompress.patch)

Updated by Oleg Plakhotniuk almost 3 years ago

  • File deleted (0002-Use-AmericanTransaction.decimal_amount-in-PayPal-mod.patch)

Updated by Oleg Plakhotniuk almost 3 years ago

  • File deleted (0003-Use-AmericanTransaction.decimal_amount-closest_date-.patch)

Updated by Romain Bignon almost 3 years ago

Hi,

Do you want I create a git repository on git.symlink.me for you? It would be easier for you to send your patches.

Updated by Oleg Plakhotniuk almost 3 years ago

  • File 0001-American-amount-to-decimal-conversion-PDF-decompress.patch added
  • File 0002-Use-AmericanTransaction.decimal_amount-in-PayPal-mod.patch added
  • File 0003-Use-AmericanTransaction.decimal_amount-closest_date-.patch added

Two days before release is a perfect timing to add some new features! I like it :-)

Here you go. Patches rebased on master branch.

Romain, thanks for asking. I'm fine now, creating patches manually is not a big pain for me yet. But if it'll be easier for you guys as well, let's do it.

Updated by Romain Bignon almost 3 years ago

It would be easier also to us to merge your patches, yes :).

Please send me a public SSH key to .

Updated by Oleg Plakhotniuk almost 3 years ago

Done. Let me know if you haven't received it. Thank you!

Updated by Romain Bignon almost 3 years ago

Your repository is created :).

We'll be able to merge your patches I think, as it may not break anything as the first one only create new functions/classes, and the two others may be fixed after release.

Updated by Oleg Plakhotniuk almost 3 years ago

Yahoo! It works!

I've pushed these patches to the following branch: http://git.symlink.me/?p=oleg/weboob.git;a=shortlog;h=refs/heads/issue1641

Please let me know if I'm doing something wrong. I'm not overwhelmingly experienced with Git.

Updated by Oleg Plakhotniuk almost 3 years ago

  • File deleted (0001-American-amount-to-decimal-conversion-PDF-decompress.patch)

Updated by Oleg Plakhotniuk almost 3 years ago

  • File deleted (0002-Use-AmericanTransaction.decimal_amount-in-PayPal-mod.patch)

Updated by Oleg Plakhotniuk almost 3 years ago

  • File deleted (0003-Use-AmericanTransaction.decimal_amount-closest_date-.patch)

Updated by Florent Fourcot almost 3 years ago

  • Status changed from To merge to Resolved

Also available in: Atom PDF