Bug #1684

Amazon module few improvements

Added by Oleg Plakhotniuk over 2 years ago. Updated over 2 years ago.

Status:Resolved Start:2014-12-07
Priority:Normal Due date:
Assigned to:Oleg Plakhotniuk % Done:

100%

Category:Modules Spent time: -
Target version:1.1
Module:amazon Branch:

Description

Skip "In transit" orders.

Generate payment transaction if there isn't one.

New discount type: "Lightning Deal".

History

Updated by Oleg Plakhotniuk over 2 years ago

  • Status changed from In progress to To merge
  • % Done changed from 50 to 100

Also fixed a bug with order charges xpath, which caused tax, shipping and discount to be 0.

Done in this branch:

http://git.symlink.me/?p=oleg/weboob.git;a=shortlog;h=refs/heads/issue1684

Updated by Romain Bignon over 2 years ago

  • Status changed from To merge to Resolved
  • Target version set to 1.1

Merged.

In df53b12d4f912a219874744b2f7e17720f7387b6, why do you break the loop at the first result?

Updated by Oleg Plakhotniuk over 2 years ago

Romain, thanks for merging!

In df53b12d4f912a219874744b2f7e17720f7387b6, why do you break the loop at the first result?

There should be only one payment method if there're no transactions. Sorry for confusion, breaking the cycle at first iteration perhaps isn't the clearest way to indicate this :-)

Also available in: Atom PDF