Commit fb87ac08 authored by Kevin Easton's avatar Kevin Easton Committed by Romain Bignon

Elements of RPL_MYINFO reply should be separate IRC-protocol arguments.

Before this patch, minbif would send a RPL_MYINFO numeric that looked like:

:harzilein.eu.org 004 Harzilein :harzilein.eu.org minbif-1.0.5(caca)(pam)(tls) o qohvb

This is parsed by clients as two arguments: "Harzilein" and
"harzilein.eu.org minbif-1.0.5(caca)(pam)(tls) o qohvb".  This is incorrect,
and causes at least EPIC4 to fail to recognise the 004 numeric.

After this patch, it is now sent as separate arguments.
Signed-off-by: 's avatarKevin Easton <caf@guarana.org>
parent db7bce71
......@@ -454,10 +454,10 @@ void IRC::sendWelcome()
user->send(Message(RPL_WELCOME).setSender(this).setReceiver(user).addArg("Welcome to the Minbif IRC gateway, " + user->getNickname() + "!"));
user->send(Message(RPL_YOURHOST).setSender(this).setReceiver(user).addArg("Your host is " + getServerName() + ", running " MINBIF_VERSION));
user->send(Message(RPL_CREATED).setSender(this).setReceiver(user).addArg("This server was created " __DATE__ " " __TIME__));
user->send(Message(RPL_MYINFO).setSender(this).setReceiver(user).addArg(getServerName() + " " +
MINBIF_VERSION + " " +
Nick::UMODES + " " +
Channel::CHMODES));
user->send(Message(RPL_MYINFO).setSender(this).setReceiver(user).addArg(getServerName())
.addArg(MINBIF_VERSION)
.addArg(Nick::UMODES)
.addArg(Channel::CHMODES));
user->send(Message(RPL_ISUPPORT).setSender(this).setReceiver(user).addArg("CMDS=MAP")
/* TODO it doesn't compile because g++ is crappy.
* .addArg("NICKLEN=" + t2s(Nick::MAX_LENGTH)) */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment